created API, Rick and Morty #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-Bruyako
suggested changes
Aug 11, 2024
| @Override | ||
| public CharacterDto getRandomCharacter() { | ||
| List<Character> characters = characterRepository.findAll(); | ||
| if (characters.isEmpty()) { |
|
|
||
| @Service | ||
| @RequiredArgsConstructor | ||
| public class CharacterServiceImpl implements CharacterService { |
There was a problem hiding this comment.
Didn't find service where you use
You must use public API (you should use REST API).
okuzan
suggested changes
Aug 16, 2024
Comment on lines
29
to
38
| HttpRequest httpRequest = HttpRequest.newBuilder() | ||
| .GET() | ||
| .uri(URI.create(URL)) | ||
| .build(); | ||
| HttpResponse<String> response = httpClient | ||
| .send(httpRequest, HttpResponse.BodyHandlers.ofString()); | ||
|
|
||
| JSONObject jsonResponse = new JSONObject(response.body()); | ||
| JSONArray resultsArray = jsonResponse.getJSONArray("results"); | ||
|
|
There was a problem hiding this comment.
this only gets 20 characters (one page), not all of them, use .next() to get next page
okuzan
suggested changes
Aug 17, 2024
| @Override | ||
| public CharacterDto getRandomCharacter() { | ||
| List<Character> characters = characterRepository.findAll(); | ||
| Random random = new Random(); |
There was a problem hiding this comment.
better extract random to a class level field, not to recreate it needlessly per each method invocation
|
|
||
| @Mapper(config = MapperConfig.class) | ||
| public interface CharacterMapper { | ||
| CharacterDto toDo(Character character); |
There was a problem hiding this comment.
Suggested change
| CharacterDto toDo(Character character); | |
| CharacterDto toDto(Character character); |
Comment on lines
54
to
56
| nextPageUrl = | ||
| jsonResponse.isNull("next") ? | ||
| null : jsonResponse.getJSONObject("info").getString("next"); |
There was a problem hiding this comment.
doesn't look nice tbh ,let's use objectMapper.readValue() to read JSON into DTOs
okuzan
approved these changes
Aug 20, 2024
| public class CharacterServiceImpl implements CharacterService { | ||
| private final CharacterRepository characterRepository; | ||
| private final CharacterMapper characterMapper; | ||
| private static final Random random = new Random(); |
There was a problem hiding this comment.
Suggested change
| private static final Random random = new Random(); | |
| private final Random random = new Random(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.